This is the mail archive of the
libc-help@sourceware.org
mailing list for the glibc project.
Re: Need help in properly formatting a patch for glibc
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: "Ryan Arnold" <ryan dot arnold at gmail dot com>
- Cc: "Denys Vlasenko" <dvlasenk at redhat dot com>, libc-help at sourceware dot org
- Date: Mon, 18 Aug 2008 15:28:58 -0400
- Subject: Re: Need help in properly formatting a patch for glibc
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=+iuIF8nI5+rwwtgbsvng4ISlY5YUoHj+celrnEGeh5E=; b=XFKrtbTPsY4KG+WwWZkPaHoS1Wii437PvxRhXvbD5I7cNB5Az25TuvLb1dXhqznnW5 TPTlNS41CoCehQBkm+HxkVnrna8sA25+mx+KpKLAwlgN6SRwPMbBurdfLXAAJQN4VxBs v+JgOZbPMYdQsaRTpqn2bzcfXVXx9uFmaZHhI=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=ZKF+XcC742maZHMqtLtsvGc1eq3HfbTQhGElWlLh1oFUZ+lC55Ty5/9Wn8b3uhV4tk JXVaK3IiFPYz1C/S2n1VKnNpbIOuj2Oh6np2Pe4PKPuPxaU/V3RkxhB8e/UcHxeYR/gt +SFpGh9UabUkoBZKcHiDqeFybL+b/Xlmjg0lQ=
- References: <1219073537.13567.11.camel@localhost.localdomain> <ff4da150808180842v31c37d79j9669efe5182b1ce@mail.gmail.com>
On Mon, Aug 18, 2008 at 11:42 AM, Ryan Arnold <ryan.arnold@gmail.com> wrote:
> On Mon, Aug 18, 2008 at 10:32 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
>> Please advice what I did wrong, and what is the correct Changelog
>> format.
Your patch also lacks the following:
1. A detailed explanation of the patch.
e.g. Under what conditions does it occur?
2. Testing.
e.g. After patching glibc, did you run the testsuite to verify your
patch didn't break anything?
Cheers,
Carlos.