This is the mail archive of the libc-help@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Need help in properly formatting a patch for glibc


On Mon, Aug 18, 2008 at 11:42 AM, Ryan Arnold <ryan.arnold@gmail.com> wrote:
> On Mon, Aug 18, 2008 at 10:32 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
>> Please advice what I did wrong, and what is the correct Changelog
>> format.

Your patch also lacks the following:

1. A detailed explanation of the patch.
e.g. Under what conditions does it occur?

2. Testing.
e.g. After patching glibc, did you run the testsuite to verify your
patch didn't break anything?

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]