This is the mail archive of the
libc-help@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Avoid preprocessor FALLOC_FL_* token redefinitions
- From: Sami Kerola <kerolasa at iki dot fi>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-help at sourceware dot org
- Date: Wed, 8 Jan 2014 09:09:32 +0000
- Subject: Re: [PATCH] Avoid preprocessor FALLOC_FL_* token redefinitions
- Authentication-results: sourceware.org; auth=none
- References: <1388614510-25958-1-git-send-email-kerolasa at iki dot fi> <201401071340 dot 41749 dot vapier at gentoo dot org>
- Reply-to: kerolasa at gmail dot com
On 7 January 2014 18:40, Mike Frysinger <vapier@gentoo.org> wrote:
> On Wednesday 01 January 2014 17:15:10 Sami Kerola wrote:
>> The linux/falloc.h header defines both FALLOC_FL_KEEP_SIZE and
>> FALLOC_FL_PUNCH_HOLE.
>
> this is not how we want to protect collisions between the kernel headers and
> the C library. see the recent threads on net/ptrace/xattrs headers instead.
>
> even all that said, unless you're calling the fallocate syscall directly, you
> shouldn't be including linux/falloc.h. if you're using using the C library's
> fallocate() function, you need to only use the C library's headers.
Hi Mike,
Got it. If anyone ever finds this thread the application change discussion can
be found from util-linux maillist archive.
http://www.spinics.net/lists/util-linux-ng/index.html#08707
--
Sami Kerola
http://www.iki.fi/kerolasa/