This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Warning fix for nptl/tls.h

From: "Carlos O'Donell" <carlos at systemhalted dot org>
To: "Jeff Bailey" <jbailey at raspberryginger dot com>
Cc: libc-ports at sources dot redhat dot com
Date: Sat, 15 Jul 2006 21:53:35 -0400
Subject: Re: Warning fix for nptl/tls.h
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=iZRQY/mrVD9v5hN3Xive7Iv0kGJJKaa4SOgVVmSpvoDDKyb3O0QxK+9GCEKmw7ORUp5Cs2TKV4xNms0wet8JyAwWeCfBxjgcfGt/QQtAVzHESwg3bNr1abSXxp5iEQkTykAdCz7KWyCBcIYCGi5zZags0I84NlXKE0INIq1NR68=
References: <20060716010010.GA25811@titanium.v3.ca>

On 7/15/06, Jeff Bailey <jbailey@raspberryginger.com> wrote:

csu/libc-tls.c expects TLS_INIT_TP to return a pointer.  This silences
the warning.

2006-07-15 Jeff Bailey <jbailey@ubuntu.com>

        * sysdeps/hppa/nptl/tls.h: Use NULL instead of 0 to avoid
        pointer conversion warning.

--- ports/sysdeps/hppa/nptl/tls.h.old   2006-07-15 10:34:30.000000000 -0400
+++ ports/sysdeps/hppa/nptl/tls.h       2006-07-15 10:34:47.000000000 -0400
@@ -102,7 +102,7 @@
    special attention since 'errno' is not yet available and if the
    operation can cause a failure 'errno' must not be touched.  */
 # define TLS_INIT_TP(tcbp, secondcall) \
-  ({ __set_cr27(tcbp); 0; })
+  ({ __set_cr27(tcbp); NULL; })

 /* Return the address of the dtv for the current thread.  */
 # define THREAD_DTV() \

Thanks Jeff! I'll check this in after I run a build.

I modified your ChangeLog entry. Your entry should include the macro
modified "(TLS_INIT_TP)" and should be as canonical as possible
"Return NULL."

Cheers,
Carlos.

References:
- Warning fix for nptl/tls.h
  - From: Jeff Bailey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]