This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH, REPOST, MIPS] Fix struct msqid_ds to match the kernel definition
- From: Daniel Jacobowitz <drow at false dot org>
- To: Thiemo Seufer <ths at networkno dot de>, Kaz Kylheku <kaz at zeugmasystems dot com>
- Cc: libc-ports at sourceware dot org
- Date: Thu, 4 Jan 2007 21:25:23 -0500
- Subject: Re: [PATCH, REPOST, MIPS] Fix struct msqid_ds to match the kernel definition
- References: <66910A579C9312469A7DF9ADB54A8B7D529463@exchange.ZeugmaSystems.local> <20061107144428.GE19541@networkno.de>
On Tue, Nov 07, 2006 at 02:44:28PM +0000, Thiemo Seufer wrote:
> Hello All,
>
> the appended patch fixes the layout of msqid_ds on Linux/MIPS and
> brings it in sync with the kernel side implementations. This patch
> was originally posted to libc-alpha three years ago
> http://sourceware.org/ml/libc-alpha/2003-10/msg00047.html.
>
> The patch is in general use in Linux/MIPS distributions, namely
> Debian and Gentoo.
Sorry, I haven't gotten to glibc since you posted this. I checked it
in.
On Thu, Jan 04, 2007 at 05:43:46PM -0800, Kaz Kylheku wrote:
> I don't see anything in the bits/msg.h definition of struct msqid_ds
> that would take care of 32 versus 64 issues. Shouldn't there be
> conditionally defined padding after the three __time_t members? For some
> other architectures like x86_64, the padding is there.
It's a little trickier than that. It was already wrong for o32. I
think Thiemo's patch that I just committed fixes it. If it doesn't,
let me know.
> Also, the n32 system call just routes the system call directly to
> sys_msgctl, where there is no wrapper that would set the IPC_64 flag. If
> you don't have that, then the IPC_OLD version is assumed: i.e. that you
> have the old obsolete version of the structure which contains a next and
> previous pointer.
Should n32 use the glibc wrappers that o32 uses?
--
Daniel Jacobowitz
CodeSourcery