This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] [HPPA] fix bits/pthreadtypes.h
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: "Aurelien Jarno" <aurelien at aurel32 dot net>
- Cc: parisc-linux at lists dot parisc-linux dot org, libc-ports at sourceware dot org
- Date: Tue, 1 May 2007 22:07:44 -0400
- Subject: Re: [PATCH] [HPPA] fix bits/pthreadtypes.h
- Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=FvRddL3/OF5O+dEU4QgqwbIDsRUJEYzK7ambhn83i72ochyV6+Ghc8ACHW2nScYTtAwkVx+BWbyt1QiJedu+gesJAt9TlSbXqWWmnapTzQcrc9hQR5N+6kvroRH/Wn9gJl7KJgEE6b7Oe70y5NGnP8o3ztLkbTKVQtxYwQtl7F4=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=DRn3bO7Lyqk30laQr8Rd1KtBZYMn5WcPOCJt384bk1V1xCkQE99tSe66pdVAL7pzFt8kiXWwv6e8MPwX2Libc3uIfA4gLmoHasIbqm7HMgvkG5HIlIGVXgHjdFetX9uJ3nOW8mpUh3IIDzcc2CGMdGNQUA2yWtsB1RejidFLhmA=
- References: <20070501192826.GA4309@amd64.aurel32.net>
On 5/1/07, Aurelien Jarno <aurelien@aurel32.net> wrote:
--- libc/ports/sysdeps/unix/sysv/linux/hppa/linuxthreads/bits/pthreadtypes.h 2007-05-01 21:15:38.000000000 +020
+++ libc/ports/sysdeps/unix/sysv/linux/hppa/linuxthreads/bits/pthreadtypes.h 2007-05-01 21:16:03.000000000 +0200
@@ -134,7 +134,7 @@
} pthread_rwlockattr_t;
#endif
-#ifdef __USE_XOPEN2K
+#if defined __USE_UNIX98 || defined __USE_XOPEN2K
/* POSIX spinlock data type. */
typedef __atomic_lock_t pthread_spinlock_t;
The generic pthreadtypes.h for linuxthreads does not define
pthread_spinlock_t, pthread_barrier_t, and pthread_barrierattr_t when
__USE_UNIX98 is defined. I don't think your patch is correct.
I have just checked in a patch to upadte pthreadtypes.h, but it's
different from your patch. Please verify this fixes the issue you were
seeing.
Cheers,
Carlos.