This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix the atomic compare and swap function on hppa

From: "Carlos O'Donell" <carlos at systemhalted dot org>
To: "Aurelien Jarno" <aurelien at aurel32 dot net>
Cc: libc-ports at sourceware dot org, parisc-linux at lists dot parisc-linux dot org
Date: Sun, 20 May 2007 11:22:18 -0400
Subject: Re: [PATCH] Fix the atomic compare and swap function on hppa
Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=ZrupAAuHD2cidVaWGT2g5spr2Tvi4sKDdtDT1lYvuo71YDiIqt3TktXmCHdPSTPJz5b5VtIlRgfLoeo6dcwrb07VnBCF06YI66TKoZHxHp4o2T9zV9c0kEJ2XJ1OEEvjczKtCc/Ys7FI1mdWkKW917mDy1kqKmTRV80HjTi7l18=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=ItEgOt31uhOoc3zeWwyYsJACeTFDg43QdLlaIlrcB3uhop220R/wQmi7jGOewZEMGOe7HZ7YGl6zXjakJSPxoklVcDwd6mgewWC8DSnrUZRxPJ/bVCAVWy69iBfr0kfbNCHg8JIuvskwx6B7xt8YXqUkav6WeKXKAaJw/mPFx1E=
References: <20070520015215.GA26949@amd64.aurel32.net> <20070520015653.GA22224@amd64.aurel32.net>

On 5/19/07, Aurelien Jarno <aurelien@aurel32.net> wrote:

2007-05-20 Aurelien Jarno <aurelien@aurel32.net>

        * sysdeps/unix/sysv/linux/hppa/bits/atomic.h: check for
        -EAGAIN instead of EAGAIN.

--- ports/sysdeps/unix/sysv/linux/hppa/bits/atomic.h.orig       2007-05-20 03:28:39.000000000 +0200
+++ ports/sysdeps/unix/sysv/linux/hppa/bits/atomic.h    2007-05-20 03:24:41.000000000 +0200
@@ -56,7 +56,7 @@
 #define LWS_CAS "0"
 /* Note r31 is the link register */
 #define LWS_CLOBBER "r1", "r26", "r25", "r24", "r23", "r22", "r21", "r20", "r28", "r31", "memory"
-#define ASM_EAGAIN "11"
+#define ASM_EAGAIN "-11"

 #if __ASSUME_LWS_CAS
 /* The only basic operation needed is compare and exchange.  */

Aurelian,

Good catch! I applaud your effort! I'll test the patch this week and
get it into cvs.

If the kernel is returning EAGAIN it means there are multiple threads
calling LWS CAS on addresses whose hash selects the same kernel
spinlock (there is an array of 16 for minimal scalability). The kernel
never spins and expects the caller to spin in userpace.

The verified the original test code I wrote does check for "-11", and
I did run the kernel tests on an SMP machine with multiple threads, so
I know that LWS CAS works on SMP.

Cheers,
Carlos.

Follow-Ups:
- Re: [parisc-linux] Re: [PATCH] Fix the atomic compare and swap function
  - From: John David Anglin
- Re: [parisc-linux] Re: [PATCH] Fix the atomic compare and swap function on hppa
  - From: Aurelien Jarno

References:
- [PATCH] Fix the atomic compare and swap function on hppa
  - From: Aurelien Jarno
- Re: [PATCH] Fix the atomic compare and swap function on hppa
  - From: Aurelien Jarno

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]