This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [Patch][RFC] ARM NPTL lll_futex_wake_unlock() issue
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: ryosei at sm dot sony dot co dot jp
- Cc: libc-ports at sourceware dot org
- Date: Wed, 10 Sep 2008 19:35:28 -0400
- Subject: Re: [Patch][RFC] ARM NPTL lll_futex_wake_unlock() issue
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=uB6eiDk6JQxGIgi96P9QbtcMyb8ZX26+rpMkDVYR4sE=; b=a3cbZsNGIkgt6l5vpMotkmTcoDrCR7awKFAef8yYaLdiIp80K94jKJHr7yVOCGX5Um Wih3nuAUK5+8x1Y8PzI0kjxuLc9CbsP5wkerRgGTuv/gVhF1c/5DLYqEldmQe1i32TZP Y5nCZMlKKlBDpjaN61NqjklZxZP+lEL3iya8g=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=Urr8HG+C9J6UZNsRQbS6NykWb6VKlIZAPta1iT2dzQnx1Vq88Dz4yQZ/U9uuafkNMr nuajLyVQjRhA3w35sGLYX6lZr3ySUs4mabri80CyYmlluT0HArKdlF1WqQa2xo+n4ReK G8xFjrQj0BNFvsZ+BRo3+UuVzDN+23re8SwHM=
- References: <20080904.231605.74741273.ryosei@sm.sony.co.jp>
On Thu, Sep 4, 2008 at 10:16 AM, <ryosei@sm.sony.co.jp> wrote:
> Could you please give me some comments??
>
> Index: glibc-2.7/glibc-ports-2.7/sysdeps/unix/sysv/linux/arm/nptl/lowlevellock.h
> ===================================================================
> --- glibc-2.7.orig/glibc-ports-2.7/sysdeps/unix/sysv/linux/arm/nptl/lowlevellock.h
> +++ glibc-2.7/glibc-ports-2.7/sysdeps/unix/sysv/linux/arm/nptl/lowlevellock.h
> @@ -110,7 +110,7 @@
> __ret = INTERNAL_SYSCALL (futex, __err, 6, (futexp), \
> __lll_private_flag (FUTEX_CMP_REQUEUE, private),\
> (nr_wake), (nr_move), (mutex), (val)); \
> - __ret; \
> + INTERNAL_SYSCALL_ERROR_P (__ret, __err); \
> })
>
>
> @@ -123,7 +123,7 @@
> __lll_private_flag (FUTEX_WAKE_OP, private), \
> (nr_wake), (nr_wake2), (futexp2), \
> FUTEX_OP_CLEAR_WAKE_IF_GT_ONE); \
> - __ret; \
> + INTERNAL_SYSCALL_ERROR_P (__ret, __err); \
> })
>
This looks correct to me. I will be applying this patch to hppa after
it completes testing.
Cheers,
Carlos.