This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ____longjmp_chk for ARM


On Mon, 18 May 2009, Andreas Schwab wrote:

> "Joseph S. Myers" <joseph@codesourcery.com> writes:
> 
> > +#define CHECK_SP(reg)				\
> > +	cmp	sp, reg;				\
> > +	ble	.Lok;				\
> > +	CALL_FAIL				\
> > +.Lok:
> 
> This is a signed compare, isn't it?  Shouldn't that rather be an
> unsigned compare?

If the stack or any object crosses the 0x80000000 or 0x00000000 boundaries 
such that the difference matters, I'd expect much more breakage.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]