This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: ____longjmp_chk for ARM
"Joseph S. Myers" <joseph@codesourcery.com> writes:
> On Mon, 18 May 2009, Andreas Schwab wrote:
>
>> "Joseph S. Myers" <joseph@codesourcery.com> writes:
>>
>> > +#define CHECK_SP(reg) \
>> > + cmp sp, reg; \
>> > + ble .Lok; \
>> > + CALL_FAIL \
>> > +.Lok:
>>
>> This is a signed compare, isn't it? Shouldn't that rather be an
>> unsigned compare?
>
> If the stack or any object crosses the 0x80000000 or 0x00000000 boundaries
> such that the difference matters, I'd expect much more breakage.
I don't see how crossing the 0x80000000 border should break anything.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."