This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix mmap2 syscall for ColdFire


On Fri, Oct 02, 2009 at 02:16:25PM +0200, Andreas Schwab wrote:
> Maxim Kuvyrkov <maxim@codesourcery.com> writes:
> 
> > Andreas Schwab wrote:
> >> Maxim Kuvyrkov <maxim@codesourcery.com> writes:
> >>
> >>> M68K linux port expects the argument of mmap2 syscall to be counted in
> >>> the memory pages.
> >>
> >> The offset is supposed to be always counted in units of 4k.
> >
> > Unfortunately, that is not the case for ColdFire.
> 
> Which is a kernel bug.

It's a long-standing kernel ABI wart.  I disagree that it's a bug, and
it would be a royal pain to have kernels with two different shift
amounts!

You can find discussions of this back to at least 2003, and I believe
uClibc has an mmap2 that agrees with current kernels.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]