This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] arm: ioperm use /proc/sys not sysctl


On Mon, Nov 9, 2009 at 12:58 AM, Eric W. Biederman
<ebiederm@xmission.com> wrote:
>
> sysctl is essentially unmaintained bloat in the linux kernel
> and is scheduled for removal in a year or so, meanwhile the
> /proc/sys interface will remain and has always existed.
>
> So use /proc/sys instead of sysctl in the implementation
> of ioperm so it continues to work even when sysctl is not
> present in the kernel.
>
> I don't have an arm build system setup so I can not easily
> verify I haven't made a stupid typo. ?get_sysctl_int does
> with other sysctl files on my x86 test machine.

Please review the contribution checklist:
http://sourceware.org/glibc/wiki/Contribution%20checklist

It is very important to test your changes on the target machine. Keep
in mind that in many cases testing is the difficult work.

At the very least your need:
* A ChangeLog
* Testing on ARM.
* Proof of FSF copyright assignment.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]