This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix mmap2 syscall for ColdFire

From: Maxim Kuvyrkov <maxim at codesourcery dot com>
To: Andreas Schwab <schwab at linux-m68k dot org>
Cc: Daniel Jacobowitz <drow at false dot org>, libc-ports at sourceware dot org
Date: Tue, 09 Feb 2010 15:27:22 +0300
Subject: Re: [PATCH] Fix mmap2 syscall for ColdFire
References: <4AC5D909.9030501@codesourcery.com> <m33a6283ep.fsf@hase.home> <4AC5E08A.8010404@codesourcery.com> <m3y6nu6leu.fsf@hase.home> <20091002203958.GA22473@caradoc.them.org> <m2vditiv4t.fsf@igel.home> <4AEADCA0.1020502@codesourcery.com>

On 10/30/09 3:31 PM, Maxim Kuvyrkov wrote:

Andreas Schwab wrote:
Daniel Jacobowitz <drow@false.org> writes:

...

It's a long-standing kernel ABI wart. I disagree that it's a bug, and
it would be a royal pain to have kernels with two different shift
amounts!

Ok. But hardcoding it is wrong, that's what getpagesize is for.


Do you have in mind something like the attached patch? Using this one
can then define MMAP2_PAGE_SHIFT to -1 in a particular port to use
getpagesize.

Let me know if you think this approach is better then simply hardcoding
the value; I'll then submit this patch to libc-alpha@ for review.

I wonder where we are on this issue. The thread seems to end at this <http://sourceware.org/ml/libc-ports/2009-10/msg00035.html> post.

Andreas, have you had a chance to look over the patch I proposed in the above post?

--
Maxim Kuvyrkov
CodeSourcery
maxim@codesourcery.com
(650) 331-3385 x724

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]