This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Arch maintainers: new approach for crti.o and crtn.o


On Fri, 10 Feb 2012, David Miller wrote:

> Is there any particular reason you hid the ASFLAGS stuff exclusively
> into the backwards compat case?  I guess it's to deal with the "defs.h"
> dependency which doesn't exist when crt{i,n}.S are provided by the
> architecture.

In general I think an improvement with the new scheme is that you avoid 
special makefile rules for these targets (instead they can be built the 
same way as other objects) and such a special rule is where the 
$(ASFLAGS-.os) was.  As noted, CPPFLAGS can be used to get these options 
in - although adding support for $(ASFLAGS-$(<F)) would be cleaner - but I 
think it's better for architectures to end up setting such a variable if 
needed for these targets (just as various architectures previously set 
special options when building initfini.c) than to have a special makefile 
rule with custom commands.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]