This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] mips: use $dir for path to ldd-rewrite.sed
On Wed, Apr 18, 2012 at 10:28 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Wednesday 18 April 2012 22:22:45 Carlos O'Donell wrote:
>> On Wed, Apr 18, 2012 at 9:51 PM, Mike Frysinger <vapier@gentoo.org> wrote:
>> > The $dest variable is based on the top build dir but we need the ldd
>> > rewrite variable to be based on the top source dir, so use $dir.
>> >
>> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>> >
>> > 2012-04-16 ?Mike Frysinger ?<vapier@gentoo.org>
>> >
>> > ? ? ? ?* sysdeps/unix/sysv/linux/mips/mips64/configure.in
>> > ? ? ? ?(ldd_rewrite_script): Change $dest to $dir.
>> > ? ? ? ?* sysdeps/unix/sysv/linux/mips/mips64/configure: Regenerate.
>>
>> What problem are you trying to solve? What's the use case that's
>> broken? I remember seeing some patches fly by about $dest vs. $dir,
>> but I haven't fully absorbed the change.
>
> http://sourceware.org/ml/libc-alpha/2012-04/msg00588.html
Thank you, that makes sense.
The patch looks good from that perspective.
I'd say check this on Friday if nobody objects.
Cheers,
Carlos.