This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] mips: use $dir for path to ldd-rewrite.sed
On Thu, 19 Apr 2012, Mike Frysinger wrote:
> On Thursday 19 April 2012 16:20:39 Joseph S. Myers wrote:
> > On Thu, 19 Apr 2012, Mike Frysinger wrote:
> > > On Thursday 19 April 2012 15:51:40 Joseph S. Myers wrote:
> > > > On Wed, 18 Apr 2012, Mike Frysinger wrote:
> > > > > The $dest variable is based on the top build dir but we need the ldd
> > > > > rewrite variable to be based on the top source dir, so use $dir.
> > > >
> > > > Could you explain:
> > > please see the URL i posted to carlos that has the background research
> >
> > That certainly doesn't say how you tested the patch (presumably in at
> > least one case that failed before the patch and passed afterwards, but you
> > don't identify what cases).
>
> i showed how it fails today:
> http://sourceware.org/ml/libc-alpha/2012-04/msg00591.html
>
> so after i made my fix, i did the same thing and saw the correct path. i
> didn't build test mips because ia64 was affected by the same issue and fixing it
> there made things build fine. ergo making the same fix to mips should work.
I still don't see a good explanation of what all these variables are,
along the following lines:
* $dir is a directory that may be an absolute path to a directory in an
add-on, if configured using an absolute path to the add-on or a relative
path to the add-on but an absolute path to srcdir, or a relative path to
that directory from the srcdir if both configure-time paths were relative.
* $dest is a path to $dir that is always valid from the top of the build
directory (and is relative if both the source directory and the path to
any add-on were relative, absolute if either of those was absolute).
* $ldd_rewrite_script may be either absolute or relative to the toplevel
source directory, but not relative to the build directory. It is used in
the elf/ subdirectory of the source directory via $(patsubst
$(..)/%,/%,$(..)$(ldd-rewrite-script)), which means "use
$(ldd-rewrite-script) if it's an absolute path, use
../$(ldd-rewrite-script) if it's a relative path".
Is that the correct meaning of the three variables? If so, the patch is
OK, but you need to include such explanations in self-contained patch
submissions to make it clear to readers why the patch is correct without
requiring multiple messages from other threads to be followed.
--
Joseph S. Myers
joseph@codesourcery.com