This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH 01/21] ia64: move from main tree
On Sun, Apr 22, 2012 at 11:37 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Saturday 21 April 2012 17:41:51 Carlos O'Donell wrote:
>> On Sat, Apr 21, 2012 at 11:57 AM, Mike Frysinger <vapier@gentoo.org> wrote:
>> > This is a simple copy of the last version of ia64 in the main tree.
>> > It does not work as-is, but serves as a basis for follow up changes
>> > to restore it to working order.
>> >
>> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>> >
>> > 2012-04-17 ?Mike Frysinger ?<vapier@gentoo.org>
>> >
>> > ? ? ? ?* sysdeps/ia64/*: Copied from the main tree.
>> > ? ? ? ?* sysdeps/unix/sysv/linux/ia64/*: Likewise.
>>
>> Please don't use "*" in a ChangeLog.
>
> i was using the style found in the top level ChangeLog. ?there are quite a
> number of "*" occurrences in there including the ia64 removal.
I'm not a fan of using "*" because the meaning is dependent upon the
state of the source tree at the time. Expanding the "*" to cover the
full set of files makes it easier for a reviewer to count files and
double check things during review.
Could you please avoid the use "*"? Alternatively start a separate
thread to talk bout it's use within the project ChangeLog.
I know it's a little more work on your end, but it helps me review.
Cheers,
Carlos.