Re: [WIP] glibc: Use /lib/ld-linux-armhf.so.3 for ARM's -mfloat-abi=hard ABI.

[Mike Frysinger <vapier at gentoo dot org>]

On Thursday 26 April 2012 17:09:36 Carlos O'Donell wrote:
> --- sysdeps/arm/preconfigure	(revision 368507)
> +++ sysdeps/arm/preconfigure	(working copy)
> 
> +		armhf_dynamic_linker="ld-linux-armhf.so.3"
> +                if `echo "$libc_cv_compiler_dynlinker_default" | grep
> "$armhf_dynamic_linker" >& /dev/null`; then

not that it matters as it sounds like this is going to be rewritten, but 
there's no need for grep here.  you can use a case statement:
	case $libc_cv_compiler_dynlinker_default in
	*$armhf_dynamic_linker*)
		... hard float ...
		;;
	*)
		... soft float ...
		;;
	esac

also, what's with the back ticks ?  i think you just wanted:
	if echo ... | grep ... ; then
rather than:
	if `echo ... | grep ...` ; then

and you don't want to use ">&" like that ... it's a bashism.  `grep -q` would 
be better, or the POSIX ">/dev/null 2>&1".
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.