This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] Fix up bswap_* types
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, libc-alpha at sourceware dot org, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>, libc-ports <libc-ports at sourceware dot org>
- Date: Wed, 22 Aug 2012 13:12:24 -0700 (PDT)
- Subject: Re: [PATCH] Fix up bswap_* types
- References: <20120819160958.GB3156@redhat.com> <Pine.LNX.4.64.1208192243590.24239@digraph.polyomino.org.uk> <20120820143509.GG3156@redhat.com> <20120821210132.C13992C0D5@topped-with-meat.com> <20120822154645.GB16963@redhat.com> <20120822164747.90AD42C0F4@topped-with-meat.com> <20120822200555.GE16963@redhat.com>
> because {,w}ctype.h contains <endian.h> and
> we end up including sysdeps/generic/stdint.h which defines macros above.
> I've circumvent that by using #ifndef _ISOMAC guard around them.
They are wrong to include <endian.h>, which declares public symbols.
They should use only <bits/endian.h> instead. This means all the various
bits/endian.h files need their #ifndef _ENDIAN_H sanity checks adjusted.
Thanks,
Roland