This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [patch, mips] Fix stubs files for hard float vs. soft float
On Mon, 2012-10-15 at 23:31 +0000, Joseph S. Myers wrote:
> On Mon, 15 Oct 2012, Steve Ellcey wrote:
>
> > On Mon, 2012-10-15 at 22:08 +0000, Joseph S. Myers wrote:
> > > On Mon, 15 Oct 2012, Steve Ellcey wrote:
> > >
> > > > While working on various flavors of glibc, I found that building on MIPS
> > > > with and without floating point enabled resulted in different stub files,
> > > > but the MIPS makefile did not handle this difference correctly (it would
> > > > always create a stubs-o32.h (or n32 or n64) header file and that file would
> > > > look different depending on whether or not you enabled floating point.
> > >
> > > What are the differences exactly? We should look at whether they are
> > > actually all correct....
> >
> > All of the soft-float versions have these entries which are not in the
> > hard float versions:
>
> OK, those do look like correct differences (unless and until MIPS
> soft-float is made to support exceptions and rounding modes along the
> lines of the support for them with Power soft-float).
Does that mean the patch is OK or do you want me to get rid of the use
of $(shell) as Roland suggested? If so, I need some help because I
don't know how to rewrite this patch to make it use a generated Makefile
instead. I am not sure what Makefile/configure script would generate
the Makefile, what targets the Makefile would have or where the
generated Makefile would be included from.
Steve Ellcey
sellcey@mips.com