This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: Don't set resource limits in tst-oddstacklimit-ENV
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>, <libc-ports at sourceware dot org>
- Date: Tue, 23 Oct 2012 19:22:36 -0700 (PDT)
- Subject: Re: Don't set resource limits in tst-oddstacklimit-ENV
- References: <Pine.LNX.4.64.1210231552390.10444@digraph.polyomino.org.uk> <20121023211159.56D832C0A2@topped-with-meat.com> <Pine.LNX.4.64.1210240108300.20540@digraph.polyomino.org.uk>
Make the top line of each new file a descriptive comment.
Two spaces after a sentence in comments.
The test should probably fail, and should certainly at least print a
complaint, if the hard limit precludes actually doing the test
meaningfully. There's no point in running tst-basic1 if you haven't
changed the limit--it's already been run that way.
Using system rather than just exec'ing the test seems dubious to me. It's
certainly a nightmare with any nontrivial command line that could have
quoting issues. You seemed to imply that we have other cases already using
system for this, which is no less troublesome but perhaps reason enough to
fry that fish another day.
Thanks,
Roland