This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: Patch: Convert linux-generic to use <bits/fcntl-linux.h>
- From: Chris Metcalf <cmetcalf at tilera dot com>
- To: Andreas Jaeger <aj at suse dot com>
- Cc: "libc-ports at sourceware dot org" <libc-ports at sourceware dot org>
- Date: Wed, 24 Oct 2012 15:31:06 -0400
- Subject: Re: Patch: Convert linux-generic to use <bits/fcntl-linux.h>
- References: <50883C05.5090807@suse.com>
On 10/24/2012 3:05 PM, Andreas Jaeger wrote:
> Here's a patch for linux-generic to use <bits/fcntl-linux.h>.
> The patch is also part of my git branch aj/shared-linux-fcntl.
Does it make sense to move the O_LARGEFILE definition to bits/fcntl-linux.h
instead, i.e. if __O_LARGEFILE is not defined, provide a definition that's
conditional on _WORDSIZE? That seems like a more natural default,
particularly as more platforms will be 64-bit with time and thus want zero
for O_LARGEFILE. <bits/wordsize.h> could either be unconditionally
included, or just included ifndef __O_LARGEFILE.
Likewise, it might make sense to take the linux-generic version of struct
flock/flock64 into bits/fcntl-linux.h, with an "#ifndef __struct_flock" or
equivalent so that platforms with variant definitions of those structures
can provide them.
This would leave us in the natural-seeming position of having linux-generic
use the generic Linux version of fcntl.h with no customizations :-)
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com