This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Optimize MIPS memcpy


On Wed, 2012-10-31 at 10:56 +1300, Maxim Kuvyrkov wrote:

> It turns out I was benchmarking my patch against original glibc implementation, not yours (patched files in ports/ instead of libc/ports).  With the patch applied correctly, the performance is virtually the same on my benchmark.  I've also checked the assembly dump of libc.so and confirmed that prefetch instructions and 8-byte loads/store are used where appropriate.
> 
> Given that your patch provides on par or better performance than mine, and it also unifies MIPS memcpy for all ABIs (as well as between glibc and Bionic!) -- I am all for your patch.
> 
> I've reviewed you patch -- code is clean and well-documented.  Please apply the patch if sufficient testing has been done: big- and little-endian for o32/n32/n64 ABIs.  I've tested your patch for all big-endian ABIs, so you just need to cover little-endian (which, I think, you may have done already).
> 
> Thanks for bearing with me through all the debugging process!
> 
> --
> Maxim Kuvyrkov
> CodeSourcery / Mentor Graphics

Sounds good.  I will run one more round of testing tonight and then
check it in tomorrow if it all goes OK.

Steve Ellcey
sellcey@mips.com



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]