This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH 1/3 ports] Add MicroBlaze Port
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: David Holsgrove <david dot holsgrove at xilinx dot com>
- Cc: <libc-ports at sourceware dot org>, John Williams <john dot williams at xilinx dot com>, "Edgar E. Iglesias" <edgar dot iglesias at gmail dot com>, Vinod Kathail <vinod dot kathail at xilinx dot com>, Tom Shui <tom dot shui at xilinx dot com>, Vidhumouli Hunsigida <vidhumouli dot hunsigida at xilinx dot com>, Nagaraju Mekala <nagaraju dot mekala at xilinx dot com>
- Date: Thu, 29 Nov 2012 16:11:36 +0000
- Subject: Re: [PATCH 1/3 ports] Add MicroBlaze Port
- References: <CAM=EW8Zoa=L8waWDSTNmQSLMe-gpDrL01p1PVFUkJ-X7eDDQLg@mail.gmail.com>
On Thu, 29 Nov 2012, David Holsgrove wrote:
> This series of patches adds glibc support for MicroBlaze architecture.
>
> The first patch adds the microblaze glibc/ports component.
You don't give any background or rationale for the design choices you
made. There are several things in this submission that don't generally
make sense for new ports.
You need to say how the port was tested. Do you have any compilation
warnings (building with GCC 4.7 or later)? If so, you need to make sure
they are architecture-independent, or do not relate to any issue with the
port itself. Do you have any testsuite failures? If so, what tests fail,
and why?
--
Joseph S. Myers
joseph@codesourcery.com