This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 5/6] Use bits/mman-linux.h for MIPS

On 03/06/2013 05:33 PM, Joseph S. Myers wrote:
On Wed, 6 Mar 2013, Andreas Jaeger wrote:

Here's an updated patch, ok now?

Andreas

2013-03-06 Andreas Jaeger <aj@suse.de>

	* sysdeps/unix/sysv/linux/bits/mman-linux.h (MAP_ANONYMOUS): Allow
	definition via __MAP_ANONYMOUS.

	ChangeLog.mips:
	* sysdeps/unix/sysv/linux/mips/bits/mman.h: Remove all defines
	provided by bits/mman-linux.h and include <bits/mman-linux.h>.
	(__MAP_ANONYMOUS): Define.


OK.  In general I think defining __* names ought to be the right approach
for architectures with more substantial differences in the values as well,
so that the architecture-specific headers never need to concern themselves
with the feature-test macros that determine when to expose non-__* names
to the user.

Yes, further cleanup steps are possible here.

Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]