This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH roland/arm-preconfigure] Clean up ARM preconfigure.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: <libc-ports at sourceware dot org>
- Date: Sat, 9 Mar 2013 01:32:13 +0000
- Subject: Re: [PATCH roland/arm-preconfigure] Clean up ARM preconfigure.
- References: <20130308225149.D30512C053@topped-with-meat.com>
On Fri, 8 Mar 2013, Roland McGrath wrote:
> This fixes the first three of those things.
The patch is OK.
> The CFLAGS tweak at the very least needs a comment explaining what it's
> there for, and why it is being done at configure time instead of just
> adding to sysdep-CFLAGS in sysdeps/arm/Makefile or something like that.
> But I have no idea what those rationales are, so I can't help there.
It's to avoid undefined references to unwinding functions at
configure-test time that would cause problems for -nostdlib link tests, so
it's set in the preconfigure script and then removed again in
sysdeps/unix/sysv/linux/arm/configure.in; it's not relevant to the build
itself.
--
Joseph S. Myers
joseph@codesourcery.com