This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH 1/2 roland/arm-sfi-macros] ARM: sfi_breg assembler macro
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: <libc-ports at sourceware dot org>
- Date: Fri, 15 Mar 2013 01:49:14 +0000
- Subject: Re: [PATCH 1/2 roland/arm-sfi-macros] ARM: sfi_breg assembler macro
- References: <20130313230841.B880B2C097@topped-with-meat.com>
On Wed, 13 Mar 2013, Roland McGrath wrote:
> * sysdeps/arm/sysdep.h [!ARM_SFI_MACROS]
> (ARM_SFI_MACROS): Define it.
> (sfi_breg, sfi_pld): New assembler macros.
> * sysdeps/arm/__longjmp.S: Use them for all memory references not
> through the pc or sp registers.
> * sysdeps/arm/add_n.S: Likewise.
> * sysdeps/arm/addmul_1.S: Likewise.
> * sysdeps/arm/arm-mcount.S: Likewise.
> * sysdeps/arm/armv6/rawmemchr.S: Likewise.
> * sysdeps/arm/armv6/strchr.S: Likewise.
> * sysdeps/arm/armv6/strcpy.S: Likewise.
> * sysdeps/arm/armv6/strlen.S: Likewise.
> * sysdeps/arm/armv6/strrchr.S: Likewise.
> * sysdeps/arm/armv6t2/memchr.S: Likewise.
> * sysdeps/arm/memcpy.S: Likewise.
> * sysdeps/arm/memmove.S: Likewise.
> * sysdeps/arm/memset.S: Likewise.
> * sysdeps/arm/setjmp.S: Likewise.
> * sysdeps/arm/strlen.S: Likewise.
> * sysdeps/arm/submul_1.S: Likewise.
OK, supposing that the changes to the iWMMXt code in setjmp / longjmp are
deliberate to avoid potential confusion from parts of a source file using
this pattern and other parts not using it. (Given that the document
pointed to implies that NaCl will define ARM_ASSUME_NO_IWMMXT, so the
iWMMXt code won't ever actually be built with the non-null version of this
macro.)
--
Joseph S. Myers
joseph@codesourcery.com