Re: [PATCH] AArch64 - Add parameter to __mount routine

[Venkataramanan Kumar <venkataramanan dot kumar at linaro dot org>]

Hi marcus,

On 16 September 2013 17:01, Marcus Shawcroft <marcus.shawcroft@gmail.com> wrote:
> On 15 September 2013 13:45, Venkataramanan Kumar
> <venkataramanan.kumar@linaro.org> wrote:
>> Hi Maintainers,
>>
>> Attached is a small patch which adds a parameter to __mcount routine.
>>
>> We would like to make the compiler pass the "frompc" address from the function
>> that calls __mcount during profiling.
>
> This is an ABI change, however, given that there is no functioning
> profiling solution using the existing interface I don't think that
> such a change is a problem.  Does anyone object?
>
>> ref: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg01556.html
>>
>> This patch is cross tested in ARMV8 foundation model. No new regressions found.
>>
>> If it is ok, someone please commit on my behalf.
>
> No regressions is a good start. How did you test the the combined
> gcc/glibc patches for profiling are working correctly?

I am cross compiling some simple tests cases and running them under in
ARMV8 model by invoking the runtime linker.

"/work/builds/gcc-fsf-trunk-patch/sysroot-aarch64-unknown-linux-gnu/lib/ld-linux-aarch64.so.1
--library-path /work/builds/gcc-fsf-trunk-patch/sysroot-aarch64-unknown-linux-gnu/lib64
test.out"

Basically do functional testing for these test cases by checking the
available gprof options.

regards,
Venkat,