This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: struct statfs/statfs64 in linux-generic
- From: Chris Metcalf <cmetcalf at tilera dot com>
- To: Chung-Lin Tang <cltang at codesourcery dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: "libc-ports at sourceware dot org" <libc-ports at sourceware dot org>, Andrew Pinski <pinskia at gmail dot com>, Marcus Shawcroft <marcus dot shawcroft at linaro dot org>
- Date: Mon, 18 Nov 2013 13:20:57 -0500
- Subject: Re: struct statfs/statfs64 in linux-generic
- Authentication-results: sourceware.org; auth=none
- References: <52774A2F dot 5010505 at codesourcery dot com> <527BF01B dot 9080704 at tilera dot com> <527F42AF dot 8060204 at codesourcery dot com> <Pine dot LNX dot 4 dot 64 dot 1311111746460 dot 18663 at digraph dot polyomino dot org dot uk> <5283357D dot 2050205 at codesourcery dot com> <Pine dot LNX dot 4 dot 64 dot 1311131258150 dot 18987 at digraph dot polyomino dot org dot uk> <528452BE dot 6020904 at codesourcery dot com> <52851656 dot 1070303 at tilera dot com> <5285CFA6 dot 8020700 at codesourcery dot com>
On 11/15/2013 2:39 AM, Chung-Lin Tang wrote:
> Yes, that works for nios2. Appears that struct stat/stat64 in
> bits/stat.h doesn't have the struct alignment attributes either.
> Updated patch attached.
>
> Chung-Lin
>
> 2013-11-13 Chung-Lin Tang <cltang@codesourcery.com>
>
> ports/
> * sysdeps/unix/sysv/linux/generic/bits/stat.h (__field64): Use
> __alignof__(type64) in alignment attribute instead of 8.
> * sysdeps/unix/sysv/linux/generic/bits/statfs.h (__field64): Use
> __alignof__(type64) in alignment attribute instead of 8.
> (struct statfs): Remove alignment attribute.
> (struct statfs64): Likewise.
The patch works fine for tilegx, so I think it should be OK to commit.
Marcus, did you want to verify that it works OK for AArch64 first?
My guess it that it should be OK for you.
Chung-Lin Tang, do you have commit access, or would you like me to
commit the change for you?
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com