This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] aarch64: Enable ifunc support.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Will Newton <will dot newton at linaro dot org>, libc-ports at sourceware dot org
- Cc: Patch Tracking <patches at linaro dot org>
- Date: Tue, 26 Nov 2013 10:19:04 -0500
- Subject: Re: [PATCH] aarch64: Enable ifunc support.
- Authentication-results: sourceware.org; auth=none
- References: <5294628E dot 30507 at linaro dot org> <5294BB3E dot 70406 at redhat dot com>
On 11/26/2013 10:16 AM, Carlos O'Donell wrote:
> On 11/26/2013 03:57 AM, Will Newton wrote:
>>
>> Add support for handling the R_AARCH64_IRELATIVE relocation and
>> STT_GNU_IFUNC symbols to the aarch64 port.
>>
>> ports/ChangeLog.aarch64:
>>
>> 2013-11-25 Will Newton <will.newton@linaro.org>
>>
>> * sysdeps/aarch64/dl-irel.h: Include ldsodefs.h.
>> (ELF_MACHINE_IRELA): Define. (elf_ifunc_invoke): Pass
>> hwcap to ifunc resolver function. (elf_irela): New function.
>> * sysdeps/aarch64/dl-machine.h: Include dl-irel.h.
>> (elf_machine_rela) Handle STT_GNU_IFUNC symbols and
>> R_AARCH64_IRELATIVE relocations. (elf_machine_lazy_rel):
>> Handle R_AARCH64_IRELATIVE relocations.
>
> You don't appear to fix elf_ifunc_invoke to pass dl_hwcap to the
> resolver which will need this to detect the different kinds of
> hardware?
Sorry, I'm wrong, I missed that line in your patch. You do pass
dl_hwcap.
c.