ctypes patches
Anthony Green
green@redhat.com
Tue Feb 26 18:12:00 GMT 2008
Thomas Heller wrote:
> Here are patches from the Python/ctypes libffi fork, for the src directory.
> It would be great if they were applied, in full or partially, to the libffi CVS repository.
>
Thanks Thomas! Comments below...
> Comments on the patch:
>
> - replace 'void (*)()' with 'void (*)(void)' everywhere.
>
> - replace C++ comments with C comments in src/x86/ffi.c
>
>
I've committed both of these.
> - (src/x86/sysv.S) Patch #1560695: Add .note.GNU-stack to ctypes' sysv.S so that
> ctypes isn't considered as requiring executable stacks.
>
See my follow-up email.
> - src/powerpc/darwin_closure.S: Try to fix the build on Mac OS X 10.3.
> The 'live_support' segment attribute is not supported in this version.
>
Hmm.. you had previously submitted test results for OS X. Was that a
different version?
Should we use a configure test to determine whether or not to use
live_support. (What is live_support anyways?)
> - powerpc/ffi_darwin.S, powerpc/darwin.S, powerpc/darwin_closure.S, x86/darwin.S:
> The complete body of these files is surrounded by a #ifdef <arch>/#endif block,
> where <arch> is the architecture to build for. This allows (with additional
> changes to configure.ac and configure) to build universal (fat) binaries on OS X.
>
I haven't committed these yet, but they are probably fine.
Thanks again...
AG
> Thomas
>
More information about the Libffi-discuss
mailing list