This is the mail archive of the libffi-discuss@sourceware.org mailing list for the libffi project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Closure test failures


Timothy Wall wrote:
One reason closure tests may be failing is that FFI_MMAP_EXEC_WRIT, which enables mmap-ing of the closure trampoline in closure.c, is only auto-enabled for gnu_linux and win32.

FFI_MMAP_EXEC_WRIT should probably be set based on HAVE_MMAP (or whatever the tests used to use) instead of checking the system type.



This minimalistic approach brings the amd64-unknown-freebsd9 testcases to a success.


I do not know about openbsd.

Anyway, this patchlet would need an autoconf _and_ an autoheader run (FFI_MMAP_EXEC_WRIT is not yet populated in fficonfig.h.in).

Andreas
--- configure.ac.orig	2009-10-06 20:01:19.000000000 +0200
+++ configure.ac	2009-10-06 20:03:04.000000000 +0200
@@ -274,7 +274,7 @@
 fi
 
 case "$target" in
-    i?86-apple-darwin10*)
+    i?86-apple-darwin10* | *-*-freebsd* | *-*-openbsd*)
 	AC_DEFINE(FFI_MMAP_EXEC_WRIT, 1,
 		  [Cannot use malloc on this target, so, we revert to
 		   alternative means])

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]