This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
Re: libffi 3.0.9rc6
- From: Andreas Tobler <andreast-list at fgznet dot ch>
- To: Anthony Green <green at redhat dot com>
- Cc: libffi-discuss at sourceware dot org
- Date: Fri, 25 Dec 2009 21:37:24 +0100
- Subject: Re: libffi 3.0.9rc6
- References: <4B3465BF.3000807@redhat.com>
Hi Anthony!
On 25.12.09 08:11, Anthony Green wrote:
Thanks for all the feedback. I've uploaded release candidate 6 here:
ftp://sources.redhat.com/pub/libffi/libffi-3.0.9rc6.tar.gz
It includes the missing patches identified by Andreas, Samuli, and
Carlo. It also includes a fix to the huge_struct test case.
And Merry Christmas to all of you celebrating today...
The same from my side!
There are three issues from my side:
First:
I probably was not clear about my part of the feedback. I had the
assumption that you followed the libffi-discuss traffic.
My 'almost' complete feedback referred to this patch:
http://sources.redhat.com/ml/libffi-discuss/2009/msg00373.html
This patch is not yet in the gcc libffi tree. I hope to get it in soon.
I think it makes sense.
With almost I mean that the closures part is now also in the standalone
libffi. So this part of the patch can also be applied now. When I wrote
and tested the patch the closures.c part for pc-solaris was missing in
the standalone part.
Also, an autoheader run is needed to populate the FFI_MMAP_EXEC_WRIT in
fficonfig.h.in.
So, this part is missing in the rc6 candidate:
* fficonfig.h.in: Regenerate.
* src/closures.c: Remove the FFI_MMAP_EXEC_WRIT definition for
Solaris/x86.
----
Index: src/closures.c
===================================================================
--- src/closures.c (revision 155394)
+++ src/closures.c (working copy)
@@ -50,11 +50,6 @@
executable memory. */
# define FFI_MMAP_EXEC_WRIT 1
# endif
-# if defined(X86_64) && defined(__sun__) && defined(__svr4__)
-/* The data segment on 64-bit Solaris/x86 isn't executable, so use mmap
- instead. */
-# define FFI_MMAP_EXEC_WRIT 1
-# endif
#endif
#if FFI_MMAP_EXEC_WRIT && !defined FFI_MMAP_EXEC_SELINUX
----
Second:
While testing the rc6 I encountered that the install.sh is not
executable, therefore configure will fail. chmod +x install.sh helps ;)
Third:
This huge_struct test fails under powerpc-*-linux, powerpc-*-freebsd9
and i386-pc-solaris2.11. I will investigate.
Thank you for your patience!
Regards,
Andreas