This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
Re: Fwd: [patch libffi]: Add support for fastcall/thiscall to x86 variant of libffi for PR 51500
- From: Kai Tietz <ktietz70 at googlemail dot com>
- To: Anthony Green <green at moxielogic dot com>
- Cc: Andrew Haley <aph at redhat dot com>, "libffi-discuss at sourceware dot org" <libffi-discuss at sourceware dot org>
- Date: Wed, 25 Jan 2012 21:36:17 +0100
- Subject: Re: Fwd: [patch libffi]: Add support for fastcall/thiscall to x86 variant of libffi for PR 51500
- References: <4F1FE048.9060600@redhat.com> <4F20651D.1090306@moxielogic.com>
2012/1/25 Anthony Green wrote:
> On 1/25/2012 5:58 AM, Andrew Haley wrote:
>>
>> This one really needs to be discussed here.
>>
>> Andrew.
>
>
> Thanks Andrew and Kai.
>
> Kai -- I had a quick look at the patch and it seems OK with me. ? Do you
> have any new test cases for it? ?As I understand it, the testsuite as is
> won't catch it because these are default ABIs as far as libffi is concerned.
>
> AG
Anthony,
You are right that libffi won't catch the new calling-convention as
they aren't default-ones.
Well, I have just one big testcase called "libjava" right now. But I
could see, if I can ellaborate some for them in second patch.
Kai