Re: libffi 3.0.12 rc2 ready for testing

[Andreas Tobler <andreast-list at fgznet dot ch>]

On 08.02.13 21:41, Matthias Klose wrote:
> Am 08.02.2013 00:10, schrieb Anthony Green:
>> Thanks for the feedback so far.  I've just uploaded the tarball of
>> release candidate 2 here:
>>
>>  ftp://sourceware.org/pub/libffi/libffi-3.0.12-rc2.tar.gz
>>
>> Again... feedback on the wiki welcome...
>> http://moxielogic.org/wiki/index.php/Libffi_3.0.12
>>
>> I'm hoping to make this the most widely tested version of libffi yet.
>> Here's what changed from yesterday...
> 
> one of the sparc related patches did break the build on sparc (32bit, using gcc
> -m32 -mcpu=v9). Looks like some tests should be
> 
>  #if defined(SPARC64) || defined(__sparc_v9__)
> 
> instead of
> 
>  #ifdef SPARC64
> 
> Matthias
> 
> 
> libtool: link: sparc-linux-gnu-gcc -shared  -fPIC -DPIC  src/.libs/prep_cif.o
> src/.libs/types.o src/.libs/raw_api.o src/.libs/java_raw_api.o
> src/.libs/closures.o src/sparc/.libs/ffi.o src/sparc/.libs/v8.o
> src/sparc/.libs/v9.o    -O2 -Wl,-z -Wl,defs -Wl,-z -Wl,relro   -Wl,-soname
> -Wl,libffi.so.6 -o .libs/libffi.so.6.0.1
> src/sparc/.libs/ffi.o: In function `ffi_call':
> /build/buildd-libffi_3.0.12~rc2-1-sparc-56QJre/libffi-3.0.12~rc2/build/../src/sparc/ffi.c:459:
> undefined reference to `ffi_call_v8'
> /build/buildd-libffi_3.0.12~rc2-1-sparc-56QJre/libffi-3.0.12~rc2/build/../src/sparc/ffi.c:447:
> undefined reference to `ffi_call_v8'
> /build/buildd-libffi_3.0.12~rc2-1-sparc-56QJre/libffi-3.0.12~rc2/build/../src/sparc/ffi.c:453:
> undefined reference to `ffi_call_v8'
> collect2: ld returned 1 exit status
> make[3]: *** [libffi.la] Error 1

This should be fixed in the git repo but it is missing in the rc2. I had
something similar here.
https://github.com/atgreen/libffi/commit/9db7e1a958fc484ba149efe027008b9a170395fb

Have a look for the v8.s, there an endif was on the wrong place.

Andreas