This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
Re: libffi ABI change causes stack corruption on Debian
- From: Anthony Green <green at redhat dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: libffi-discuss at sourceware dot org
- Date: Thu, 21 Nov 2013 19:43:51 -0500
- Subject: Re: libffi ABI change causes stack corruption on Debian
- Authentication-results: sourceware.org; auth=none
- References: <OFCC53E675 dot 090279F5-ONC1257C29 dot 006A1ED2-C1257C29 dot 006B0A1A at de dot ibm dot com> <20131120223825 dot GJ22514 at bubble dot grove dot modra dot org> <20131121103907 dot GB3588 at bubble dot grove dot modra dot org> <87r4aajahn dot fsf at redhat dot com> <878uwij9pm dot fsf at redhat dot com> <20131121233026 dot GD3588 at bubble dot grove dot modra dot org>
Alan Modra <amodra@gmail.com> writes:
> On Thu, Nov 21, 2013 at 06:05:57AM -0500, Anthony Green wrote:
>> Committing shortly...
>
> fficonfig.h.in needs regenerating..
Oops. I'll fix this.
> On other projects we usually don't
> include regenerated files in a patch, instead just mention the file in
> the ChangeLog to prod a maintainer to do the regeneration. Would you
> rather I submit patches that include generated files?
No, I'll regenerate. As far as process goes, however, I'm really
starting to like github pull requests.
Thanks,
AG