mkcheck breakage (and repairage)
Phil Edwards
pedwards@disaster.jaj.com
Tue Mar 13 09:55:00 GMT 2001
This change
2001-03-12 Felix Lee <flee@redhat.com>
* mkcheck.in: workaround for bash 2.01 IFS bug.
makes mkcheck work correctly *only* for 2.01 now. Before the change,
CXXFLAGS was set to "-ggdb3 -DDEBUG_ASSERT" and INCLUDES was set
to "-I/home/pme/src/unified/libstdc++-v3/testsuite" but now it's
CXXFLAGS="-ggdb3" and INCLUDES="-DDEBUG_ASSERT". This causes every test
to fail to compile, since the -Ipath is lost and debug_assert.h can no
longer be found.
I am committing the following patch. Please test that it works for
bash 2.01. (Since mkcheck is a temporary stopgap measure, I'm not as
concerned about bug-for-bug compatability with older bash'es as we would
be if mkcheck were a permanent thing...)
Index: mkcheck.in
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/mkcheck.in,v
retrieving revision 1.51
diff -u -3 -p -r1.51 mkcheck.in
--- mkcheck.in 2001/03/12 21:52:29 1.51
+++ mkcheck.in 2001/03/13 17:46:30
@@ -52,7 +52,11 @@ esac
# Compute the flags necessary to run the testsuite.
saved_ifs=$IFS
# bash 2.01 does the wrong thing with $* if IFS doesn't include space
-IFS=': '
+if test ${BASH_VERSINFO[1]} = 01 ; then
+ IFS=': '
+else
+ IFS=':'
+fi
set `../tests_flags ${query} $*` || exit 1
BUILD_DIR=$1; SRC_DIR=$2; PREFIX_DIR=$3; CXX=$4; CXXFLAGS=$5; INCLUDES=$6; LIBS=$7;
IFS=$saved_ifs
More information about the Libstdc++
mailing list