libsupc++ nit picks

Phil Edwards pedwards@disaster.jaj.com
Thu Jan 3 16:03:00 GMT 2002


On Thu, Jan 03, 2002 at 11:36:26PM +0000, Nathan Myers wrote:
> > Also, the use of qualified names, usings, and extern
> > vs #include seem inconsistent.
> > To use the above example again, del_op.cc and
> > del_opnt.cc refer to ::free, where eh_globals.cc uses
> > std::free.
> 
> Standard names used within standard implementations should always 
> be qualified with "std::", either explicitly or through a 
> using-declaration in an enclosing (not global!) scope.  Without
> a qualification, you may risk ambiguity with or (worse) diversion 
> to another function of the same name in a user's namespace, through
> Koenig lookup.

This is still an open issue, isn't it?  Core DR 229, Library DR 225,
226, 229 all deal with this question.  The latest Issues Lists still have
"we don't know what to do here" for these points.

Clearly for libsupc++ we should only use std:: names, but for the rest of
the library that is not so clear.


Phil

-- 
If ye love wealth greater than liberty, the tranquility of servitude greater
than the animating contest for freedom, go home and leave us in peace.  We seek
not your counsel, nor your arms.  Crouch down and lick the hand that feeds you;
and may posterity forget that ye were our countrymen.            - Samuel Adams



More information about the Libstdc++ mailing list