Patch to fix irix5 & irix6 libstdc++-v3 scan_not() implementations
Benjamin Kosnik
bkoz@redhat.com
Mon May 13 11:02:00 GMT 2002
> I did see ctype_members_char and considered adding my test to that
> file, however I noted that it is currently contains this:
>
> // XXX This test (test02) is not working for non-glibc locale
> models.// { dg-do run { xfail *-*-* } }
>
> This makes adding my test to it useless as a mechanism for catching
> broken scan implementations.
Right.
> IMHO, the convention of adding test#() functions to existing
> libstdc++-v3 tests is really a bad idea, since you lose every test in
> the file when it's marked xfail like this. We should consider
> breaking out every test#() function into its own main() in its own
> file. Or at least do so for tests marked xfail so the other test
> functions in that file get checked properly and appear as real
> failures if they break.
... true. A solution that tests just the "C" locale model, and adds in
named locales conditionally might be a better way of organizing this
particular directory.
I agree, in general, about breaking up some of the bigger files though.
I've been planning on doing this to the io testsuite for about a year.
> Yes, I'll have to pass on the wchar test. So I accept your offer to
> do it instead. :-)
I just did it. Thanks!
-benjamin
More information about the Libstdc++
mailing list