PATCH: TR1 unordered associative containers
Chris Jefferson
caj@cs.york.ac.uk
Fri Feb 18 00:33:00 GMT 2005
Joe Buck wrote:
>On Thu, Feb 17, 2005 at 03:47:03PM -0800, Matt Austern wrote:
>
>
>>I'm sure there are still lots of horrible bugs, which will only be
>>found with a more complete test suite. But the core functionality
>>works, and at this point I think it'll improve faster in the CVS server
>>than sitting on my hard disk.
>>
>>OK to commit to mainline?
>>
>>
>
>A namespace purity nitpick:
>
>You define a macro named tr1_hashtable_define_trivial_hash. Shouldn't
>that be __tr1_hashtable_define_trivial_hash or something similar?
>
>
Having just read through, everything seems very reasonable to me, but I
think there is a general need a liberal splattering of __ here, there
and everywhere :) It would be very nice if we could stop having to
prefix everything with __ and just pop it into a namespace instead, but
fixing that is perhaps something for another day :)
Chris
More information about the Libstdc++
mailing list