[libstdc++ PATCH] Fix leak in _Rb_tree::_M_insert (stl_tree.h)

Paolo Carlini pcarlini@suse.de
Fri Feb 25 15:24:00 GMT 2005


Hi Chris,

> I apologise if I'm saying something really stupid, but from my looking 
> at the source code to stl_tree.h, it looks like _M_create_node just 
> allocates memory and doesn't actually do any tree based things. 
> Therefore why not just delay declaring the _Link_type until after the 
> __insert_left initalisation? Then there is no need for a 
> try{...}catch{...}

I think you are right, seems a much better solution! ;)

To be safe, we should ask Earl to run again that testsuite...

Paolo.



More information about the Libstdc++ mailing list