[PATCH] Remove volatile qualifiers from mt_allocator
Paolo Carlini
pcarlini@suse.de
Wed Aug 30 12:35:00 GMT 2006
Richard Guenther wrote:
>We can "fix" that particular code by doing this adjustment
>
> // Return this block to our list and update counters and
> // owner id as needed.
> --__bin._M_used[__block->_M_thread_id];
>
>only if __block->_M_thread_id == __thread_id as _M_used is only used to
>optimize reclaiming of thread-local free lists here:
>
>
[snip]
and I think you are totally right! I was already considering that change
myself (nothing in bugzilla, sorry), especially so when we noticed some
time ago that an *unrelated* change that inadvertently amounted to the
same effect apparently did work fine and didn't cause any major problem.
Are you willing to test it on a multiway machine? That would mean in
particular running the performance testsuite before and after and
studying the 23_containers numbers...
Thanks,
Paolo.
More information about the Libstdc++
mailing list