Remove algo logic duplication Round 3
Paolo Carlini
paolo.carlini@oracle.com
Mon Sep 23 22:37:00 GMT 2013
On 9/23/13 5:30 PM, Marc Glisse wrote:
> On Mon, 23 Sep 2013, Paolo Carlini wrote:
>
>> On 9/23/13 4:48 PM, Marc Glisse wrote:
>>> I meant putting the "inline" keyword explicitly, because the inliner
>>> uses that as a heuristic. But forget it.
>> Does it really do that?!? Frankly I had no idea that was the case,
>> and in the library we (I think I can say we, because the code says
>> that) always assume that since the inline is implicit at least for
>> linkage purposes it was for actual inlining purposes too, end of the
>> story. Is that "hint" officially documented somewhere or you reverse
>> engineered somehow by yourself?
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51680
Funny, I don't remember making that comment at all, and isn't that old ;)
Anyway, things appear to be moving relatively quickly in this area, for
now at least let's not start adding additional inline everywhere, and
let's reconsider the issue later, only if we notice something weird
happening with actual code involving the algorithms.
Paolo.
More information about the Libstdc++
mailing list