Improve std::rotate usages

François Dumont frs.dumont@gmail.com
Tue Jul 24 10:23:00 GMT 2018


Ping.

On 08/06/2018 07:54, François Dumont wrote:
> Gentle reminder.
>
> On 27/05/2018 19:25, François Dumont wrote:
>> Still no chance to review it ?
>>
>> I'd like this one to go in before submitting other algo related patches.
>>
>>     * include/bits/stl_algo.h
>>     (__rotate(_Ite, _Ite, _Ite, forward_iterator_tag))
>>     (__rotate(_Ite, _Ite, _Ite, bidirectional_iterator_tag))
>>     (__rotate(_Ite, _Ite, _Ite, random_access_iterator_tag)): Move 
>> code duplication...
>>     (rotate(_Ite, _Ite, _Ite)): ...here.
>>     (__stable_partition_adaptive(_FIt, _FIt, _Pred, _Dist, _Pointer, 
>> _Dist)):
>>     Simplify rotate call.
>>     (__rotate_adaptive(_BIt1, _BIt1, _BIt1, _Dist, _Dist, _Bit2, 
>> _Dist)):
>>     Likewise.
>>     (__merge_without_buffer(_BIt, _BIt, _BIt, _Dist, _Dist, _Comp)):
>>     Likewise.
>>
>> François
>>
>> On 14/05/2018 22:14, François Dumont wrote:
>>> Any feedback regarding this patch ?
>>>
>>>
>>> On 02/05/2018 07:26, François Dumont wrote:
>>>> Hi
>>>>
>>>>     std::rotate already returns the expected iterator so there is 
>>>> no need for calls to std::advance/std::distance.
>>>>
>>>> Tested under Linux x86_64, ok to commit ?
>>>>
>>>> François
>>>>
>>>
>>
>



More information about the Libstdc++ mailing list