Re: Patch: GUI testing framework

[Thomas Fitzsimmons <fitzsim at redhat dot com>]

On Tue, 2005-01-04 at 10:02 +0100, Michael Koch wrote:
> Am Dienstag, 4. Januar 2005 00:36 schrieb Thomas Fitzsimmons:
> > Hi,
> >
> > This patch adds support to batch_run for running GUI tests, either
> > within an Xvfb server (default) or directly on the tester's
> > desktop.  It also introduces the GUI tag; all tests that require
> > DISPLAY to be set should be tagged as GUI tests.
> >
> > I tested this with the java.awt.Robot tests I posted last week. 
> > The tests run properly both within Xvfb and on my desktop.
> 
> Nice. Classpath has it now too, so we can generally test it too 
> directly.
> 
> > I would like to rely on the metacity window manager, since it
> > handles inset sizing correctly.
> 
> Depending on a specific window manager is stupid. It just makes the 
> hurdles for users of mauve higher. If we have problems with a 
> specific window manager and its his fault and not ours we should 
> report bugs.
> 

OK.  Can we default to metacity?  I'm thinking of:

if test "x$WM" = "x" ; then
    WM=metacity
fi

Then you could set WM on the command line.

Tom