This is the mail archive of the newlib@sources.redhat.com mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH/RFA add "access" function for ARM


Richard Earnshaw wrote:
> 
> > Richard Earnshaw wrote:
> > > PS, I'm not on this mailing list; please cc me directly on any follow up.
> > >
> > > <date>  Richard Earnshaw  <rearnsha@arm.com>
> > >
> > >         * sys/arm/access.c: New file.
> > >         * sys/arm/Makefile.am (lib_a_SOURCES): Add it
> > >         * sys/arm/Makefile.in: Regenerate.
> > >         * sys/arm/syscalls.c (_stat): New function.
> > >
> >
> > Richard,
> >
> >   First of all, we don't add files with the copying.dj licence
> > in regular directories any more.  As it so happens, the access.c
> > file licence has been relaxed by DJ in the past and we can take a copy
> > from the libgloss/mn10300 directory which has the less restrictive
> > licence.
> 
> I just copied the one out of the sys/go32 directory.  If there are other
> copies with more appropriate licences, I've no problem with that.
> 
> >
> >   Can you comment on whether the change to _fstat is needed by f77
> > (i.e. is it just there to support _stat and thus: access() or does f77
> > rely on fstat returning S_IFREG | S_IREAD for st_mode).  I would prefer
> > to remove the call to _fstat and just set st manually since _stat
> > has confirmed that the file is regular and readable, not _fstat.
> > I have included a modified version of the patch in case you want
> > to verify whether the _fstat change is needed.
> 
> Your suggested patch works just as well in the g77 testsuite.
> 

Patch checked in.

-- Jeff J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]