This is the mail archive of the newlib@sources.redhat.com mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, arm] Add support for .init_array


Hi Paul,

The Arm eabi requires the use of the .init_array section for running static constructors. The attached patch implements the required startup code for running these.

Tested with cross to arm-none-eabi and arm-none-elf.
Ok?

I am not able to approve this patch, but I do have a couple of minor comments on it...


* We are attempting to move the ARM startup code out of newlib and into libgloss, so your patch to libc/sys/arm/crt0.S ought to be duplicated in libgloss/arm.crt0.S

* It is normally OK to omit a patch to auto-generated files (eg newlib/configure, libc/misc/Makernel.in) and instead rely upon the committer to make sure that such files are regenerated.

* In my opinion new source files such as libc/misc/init.c ought to include a copyright notice at the start. I know that other source files in the misc/ directory do not have this, so this is just a suggestion.

Cheers
  Nick



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]