This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
RE: [PATCH 3/5] spe-newlib-gc-sections
- From: "Dave Korn" <dave dot korn at artimi dot com>
- To: "'jschopp'" <jschopp at austin dot ibm dot com>
- Cc: <newlib at sources dot redhat dot com>
- Date: Fri, 4 Aug 2006 17:16:19 +0100
- Subject: RE: [PATCH 3/5] spe-newlib-gc-sections
On 04 August 2006 16:48, jschopp wrote:
>>> Because each of the SPEs operate in their own 256K address space, newlib
>>> is always statically linked. Adding these flags will thus reduce the
>>> size of applications that link against newlib.
>>
>>
>> This patch seems to have been mangled in transit!
>
> Thanks for letting me know. Not sure what happened there, I'll be sure to
> find out. In the meantime here is the patch, hopefully unmangled.
Yeh, that's better!
BTW, you were asking about coding style issues. Newlib is a redhat project
rather than a GNU one, but the GNU coding standards are always a good set of
basic guidelines. If you haven't seen them, take a look at
http://www.gnu.org/prep/standards/
- particularly the bit about how to lay out a ChangeLog entry (section 6.8),
because none of your patches came with one of those, and you're going to get
asked for them!
cheers,
DaveK
--
Can't think of a witty .sigline today....