This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] add bfin target


On 9/26/06, Jeff Johnston <jjohnstn@redhat.com> wrote:
Hi Michael,

   I just noticed that your patches are testing for the BFIN flag.
Platform macros such as this are normally underscore-prefixed to avoid
clashing with the user macro namespace.

   Is there an __BFIN__ or __bfin__ alternative that can be used or is
there some change required to the bfin compiler?

-- Jeff J.

I really don't know, I was wondering myself about the predefined macros not following the normal convention.

As far as I can tell, the predefines are set in gcc/config/bfin/bfin.h
(grep for "builtin_define"). However, after greping the whole GCC
source, bfin stands out as one of the very few that doesn't follow the
underscore naming convention.

I suspect this might be a typo by the author, and is perhaps also
related to why one can't rebuild the GCC sources a second time (for
bfin) without ripping out all previous installations (or is it just
me?). The second time the BFIN macro is not honored in
newlib-1.14.0-orig/newlib/libc/include/machine/ieeefp.h and I get the
'#error Endianess not declared!!'

I was poking around in the GCC CVS tree looking for any trails, but so
far no one seems to have observed this peculiarity.

Perhaps someone can fill in with additional hints?

Regards
/Michael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]