This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] libgloss/arm: Move do_AngelSWI to swi.h.

From: Kazu Hirata <kazu at codesourcery dot com>
To: Nick Clifton <nickc at redhat dot com>
Cc: newlib at sources dot redhat dot com, paul at codesourcery dot com
Date: Sat, 23 Dec 2006 20:34:17 -0500
Subject: Re: [patch] libgloss/arm: Move do_AngelSWI to swi.h.
References: <200612201059.kBKAxjaV032613@sparrowhawk.codesourcery.com> <458DD5C8.703@redhat.com>

Hi Nick,

Attached is a patch to move do_ANgelSWI to swi.h.
Do you have a particular reason for wanting to do this ?

After all the function seems to be perfectly happy where it is, and there are no other users of it, so why move it into the header file ?

There are two copies of do_AngelSWI -- one in libfunc.c and the other in syscalls.c. I thought it would be nice to have a single copy to avoid duplicates.

Thanks,

Kazu Hirata

Follow-Ups:
- Re: [patch] libgloss/arm: Move do_AngelSWI to swi.h.
  - From: Nick Clifton

References:
- [patch] libgloss/arm: Move do_AngelSWI to swi.h.
  - From: Kazu Hirata
- Re: [patch] libgloss/arm: Move do_AngelSWI to swi.h.
  - From: Nick Clifton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]