This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] libgloss/arm: Cast arguments to do_AngelSWI to int.

From: Paul Brook <paul at codesourcery dot com>
To: Nick Clifton <nickc at redhat dot com>
Cc: Kazu Hirata <kazu at codesourcery dot com>, newlib at sources dot redhat dot com
Date: Mon, 25 Dec 2006 20:12:48 +0000
Subject: Re: [patch] libgloss/arm: Cast arguments to do_AngelSWI to int.
References: <200612201047.kBKAllCm025497@sparrowhawk.codesourcery.com> <200612240151.40602.paul@codesourcery.com> <459029C3.1020004@redhat.com>

> I take your point about the union being a little heavy handed for what
> is being coded here, but given the number of subtle problems that can be
> caused by aliasing, I think that it is wise to always code pointer to
> integer conversions using unions, even when they do not appear to be
> necessary.  Better safe than sorry.

I'm not convinced by your argument. Aliasing int and void* via unions is a gcc 
extension. Casting a void* to an int is legal C.

Paul

Follow-Ups:
- Re: [patch] libgloss/arm: Cast arguments to do_AngelSWI to int.
  - From: Nick Clifton

References:
- [patch] libgloss/arm: Cast arguments to do_AngelSWI to int.
  - From: Kazu Hirata
- Re: [patch] libgloss/arm: Cast arguments to do_AngelSWI to int.
  - From: Paul Brook
- Re: [patch] libgloss/arm: Cast arguments to do_AngelSWI to int.
  - From: Nick Clifton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]